Conversation
henderkes
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adjusts FrankenPHP’s Prometheus metrics shutdown behavior to avoid a race during shutdown/reload by stopping Shutdown() from mutating metric fields and from recreating/re-registering core thread metrics after unregistering them.
Changes:
- Remove
nilassignments for worker-related collectors duringPrometheusMetrics.Shutdown(). - Stop recreating and re-registering
totalThreads,busyThreads, andqueueDepthinsideShutdown()after unregistering them.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As far as I can see this is wasted anyway, because a reload leads to a new provision which always creates new ones. Requests still served on the old app shouldn't actually have their stats cleared either, I think?